update Ethereumjs 10 / ethers 6 #5980
Merged
+2,100
−493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
yann300
force-pushed
the
ethereumjs_10
branch
12 times, most recently
from
e137411 to
f3d0bd8
Compare
yann300
force-pushed
the
ethereumjs_10
branch
7 times, most recently
from
e7cabc3 to
2dc6610
Compare
Aniket-Engg
reviewed
May 1, 2025
libs/ghaction-helper/src/methods.ts
Outdated
| @@ -1,8 +1,8 @@ | |||
| // @ts-ignore | |||
| import { ethers } from "ethers" | |||
| import { BrowserProvider, Contract, Signer } from "ethers" | |||
There was a problem hiding this comment.
these two imports can be merged in one
| const abi = new ethers.utils.Interface([funABI]) | ||
| return abi.getSighash(funABI.name) | ||
| const abi = new Interface([funABI]) | ||
| console.log('encodeFunctionId', abi.getFunction(funABI.name).selector) |
| import { hash } from '@remix-project/remix-lib' | ||
| import { bytesToHex, Account, bigIntToHex, MapDB, toBytes, bytesToBigInt, BIGINT_0, BIGINT_1, equalsBytes } from '@ethereumjs/util' | ||
| import { keccak256 } from 'ethereum-cryptography/keccak' | ||
| import { bytesToHex, hexToBytes, Account, bigIntToHex, MapDB, toBytes, bytesToBigInt, BIGINT_0, BIGINT_1, equalsBytes, createAccount, PrefixedHexString } from '@ethereumjs/util' | ||
| import { Address } from '@ethereumjs/util' |
There was a problem hiding this comment.
this import can be merge with above one
Aniket-Engg
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.