-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Bump evmone to 0.13.0 #15825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump evmone to 0.13.0 #15825
Conversation
@@ -1 +0,0 @@ | |||
./build.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was removed because we dropped Ubuntu 20.04 from our buildpack-deps but forgot to delete the symlink.
For reference, these buildpack-deps_test*
scripts are used here:
solidity/scripts/ci/docker_upgrade.sh
Line 59 in ccd6047
bash -c "/project/scripts/ci/${IMAGE_NAME}_test_${IMAGE_VARIANT}.sh" |
scripts/ci/docker_upgrade.sh ${{ env.IMAGE_NAME }} ${{ matrix.image_variant }} ${{ env.DOCKER_REPOSITORY }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way - why didn't you remove ubuntu2004 from GH workflows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way - why didn't you remove ubuntu2004 from GH workflows?
Oh, forgot about it, but it should be removed indeed.
|
|
|
|
I canceled the rebuild of the images after rebasing the branch, but the successful build of the images can be seen here: https://github.com/ethereum/solidity/actions/runs/13135391295 |
cd evmone; \ | ||
mkdir build; \ | ||
cd build; \ | ||
CXX=clang++ cmake -G Ninja -DBUILD_SHARED_LIBS=OFF -DCMAKE_INSTALL_PREFIX="/usr" ..; \ | ||
CXX=clang++ cmake .. -G Ninja \ | ||
-DCMAKE_CXX_STANDARD=20 -DCMAKE_CXX_FLAGS="-stdlib=libc++" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-DCMAKE_CXX_STANDARD=20 -DCMAKE_CXX_FLAGS="-stdlib=libc++" \ | |
-DCMAKE_CXX_FLAGS="-stdlib=libc++" \ |
this is set from within cmake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this is not compiling solidity but evmone, but they indeed already set it in the cmake: https://github.com/ethereum/evmone/blob/dd38ff4fdea410908f397a5c7115c2877e064c05/lib/evmone/CMakeLists.txt#L33
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting the standard from outside is non-critical, it's just something that has to be adapted once we update to, e.g., c++23
3ee1b91
to
693b094
Compare
693b094
to
719fc8b
Compare
This PR bumps evmone to 0.13.0 and fixes a build issue with Boost and Clang 18 in our ossfuzz docker image. It adds the
-nostdinc++
compiler flag when building Boost to disable searching for headers in the default C++ standard directories, ensuring Clang explicitly looks for the libc++ headers in the correct location.Additionally, it includes a workaround for libprotobuf-mutator. Unfortunately, I couldn’t get it to work with libprotobuf-mutator v1.3.