Add builtin erc7201 #15968
Add builtin erc7201 #15968
Conversation
| { | ||
| case FunctionType::Kind::ERC7201: | ||
| { | ||
| solAssert(_functionCall.arguments().size() == 1); |
There was a problem hiding this comment.
Shouldn't we report an error instead?
There was a problem hiding this comment.
That is already checked in TypeChecker::typeCheckFunctionGeneralChecks.
I think also it doesn't make sense to raise such error here.
But your question touches on something I am uncomfortable still in extending the ConstantEvaluator, which is depending/assuming that analysis step already passed.
| solAssert(argument); | ||
| ASTString argStringLiteral = argument->valueWithoutUnderscores(); | ||
| auto value = | ||
| u256(keccak256(h256(u256(keccak256(argStringLiteral)) - 1))) & |
There was a problem hiding this comment.
Why the u256 conversion here? Isn't better to work with bytes and only convert everything to u256 when necessary?
There was a problem hiding this comment.
I have to check that but looks like probably those conversions can be skipped.
I just tentatively reconstructed from the solidity spec here.
At least the computed values from both versions (cpp and solidity) were matching in the test I did in remix.
part of #15727.