This repository was archived by the owner on Jul 1, 2021. It is now read-only.
Use asyncio.Server as an async ctx manager in our TCP listener #1763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was added on py37, and ensures we don't silence crashes in our TCP listener server
gsalgado
commented
Jun 1, 2020
| "websockets>=8.1.0", | ||
| "jsonschema==3.0.1", | ||
| "mypy-extensions>=0.4.3,<0.5.0", | ||
| "typing_extensions>=3.7.4,<4.0.0", |
There was a problem hiding this comment.
We don't need this anymore as we no longer support py36
gsalgado
requested review from
cburgdorf and
pipermerriam
and removed request for
cburgdorf and
pipermerriam
cburgdorf
approved these changes
Jun 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added on py37, and ensures we don't silence crashes in our TCP listener server
Another occurrence of ethereum/snake-charmers-tactical-manual#70