PortalClient: Rebuild node from memory #767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acolytec3
approved these changes
Apr 18, 2025
Collaborator
acolytec3
left a comment
acolytec3
left a comment
There was a problem hiding this comment.
LGTM.
Note, I added a couple of commits.
- Remove the debug shim as this is unnecessary.
- Added the
portalnetworkclient as an object on theWindowasWindow.portalso you can access the portalnetwork client directly for debugging.
acolytec3
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the application by persisting the node details
to prevent fresh node creation on every initialisation.
getPrivateKey,savePrivateKey)