Skip to content

central event bus #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

central event bus #792

wants to merge 8 commits into from

Conversation

ScottyPoi
Copy link
Collaborator

@ScottyPoi ScottyPoi commented May 19, 2025

Central Event Bus

This PR introduces a new event bus system and refactors the PortalNetwork and BaseNetwork classes to use it instead of extending EventEmitter. This change improves the architecture by decoupling event handling from the network classes and providing a more centralized event management system.

Changes

  1. Added new eventBus class and updated types
  2. Updated PortalNetwork class to use eventBus instead of extending EventEmitter
  3. Updated Network classes to use eventBus instead of extending EventEmitter
  4. Updated downstream event calls in the portal network
  5. Updated tests to reflect the new event bus implementation

@ScottyPoi ScottyPoi marked this pull request as draft May 19, 2025 23:41
@ScottyPoi ScottyPoi closed this May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant