Move all event handling to PortalNetwork class #793
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
his PR removes direct EventEmitter inheritance from Network classes and restructurs how events are handled across the Portal Network implementation.
The changes introduce namespaced events and centralize event handling through the PortalNetwork class
Changes
Remove EventEmitter inheritance from Network classes
Implement namespaced events using network IDs (e.g.,
${networkId}:ContentAdded
)Move event handling from Network classes to PortalNetwork class
Update event listeners and emitters across all network implementations
Update tests
BaseNetwork classes
this.portal
instead of directlyEvent Handling