chore: use ffi_interface API
#20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd fix class import
gabrocheleau
approved these changes
Feb 11, 2024
|
Ugh, this is really pretty extensive work! 🤯 Thanks a lot for addressing this so super-quickly! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new API which relies on the
ffi_interfaceAPI that has been recently been added.This is the same API that is being used in the besu client and so this should allow one to debug between clients easier.
In terms of performance degradation, I think we can use raw pointers if we want to squeeze out performance, the downside of raw pointers is that memory management is left upto the developer.