Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: The conversion from SBP ECEF or WGS84 measurement to ENU with geotf was erroneous because of the projection type geotf uses (see ethz-asl/geodetic_utils#53).
In this PR we replace geotf by geographiclib which gives conversions between ECEF<->WGS84<->ENU.
We tested this PR with historic data in a unit test as well as on the hardware. Here we set up the base station approximately 250m away from the rover and set the base station antenna position to be the ENU origin.
pos_enu
published by our driver andbaseline_ned
published by Piksi should now coincide.OLD master
Difference:
0.304
This is terrible!New fix/geotf
Difference:
0.0006
This is excellent! It is within the mm resolution of baseline_ned.This PR closes #227