Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/geotf #229

Merged
merged 4 commits into from
Oct 3, 2022
Merged

Fix/geotf #229

merged 4 commits into from
Oct 3, 2022

Conversation

rikba
Copy link
Collaborator

@rikba rikba commented Oct 3, 2022

Problem: The conversion from SBP ECEF or WGS84 measurement to ENU with geotf was erroneous because of the projection type geotf uses (see ethz-asl/geodetic_utils#53).

In this PR we replace geotf by geographiclib which gives conversions between ECEF<->WGS84<->ENU.

We tested this PR with historic data in a unit test as well as on the hardware. Here we set up the base station approximately 250m away from the rover and set the base station antenna position to be the ENU origin. pos_enu published by our driver and baseline_ned published by Piksi should now coincide.

OLD master

/rover/piksi/position_receiver_0/ros/pos_enu
  east: 46.169826148400524
  north: -244.57162264061503
  up: -4.039364604279399
/rover/piksi/position_receiver_0/ros/baseline_ned
  east: 46.257
  north: -244.28
  up: -4.0440000000000005

Difference: 0.304 This is terrible!

New fix/geotf

/rover/piksi/position_receiver_0/ros/pos_enu
  east: 46.27259394353746
  north: -244.25576613787558
  up: -4.042596601441858
/rover/piksi/position_receiver_0/ros/baseline_ned
  east: 46.273
  north: -244.256
  up: -4.043

Difference: 0.0006 This is excellent! It is within the mm resolution of baseline_ned.

This PR closes #227

@rikba
Copy link
Collaborator Author

rikba commented Oct 3, 2022

This also reduces catkin dependencies.

@rikba rikba merged commit 955ac37 into master Oct 3, 2022
@rikba rikba deleted the fix/geotf branch October 3, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coordinate transformation is wrong
1 participant