Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gdal from package definitions #48

Closed
wants to merge 1 commit into from

Conversation

Jaeyoung-Lim
Copy link
Member

@Jaeyoung-Lim Jaeyoung-Lim commented May 20, 2021

Problem Description
The pacakage.xml specifies GDAL as a dependency, which rosdep is not able to handle.

ERROR: the following packages/stacks could not have their rosdep keys resolved

to system dependencies:

geotf: Cannot locate rosdep definition for [GDAL]

Removing GDAL from the package definitions resolves this problem, and the package builds as long as gdal is properly installed in the system.

This is useful for me, since I am installing package dependencies thorugh rosdep which has a dependency to geodetic_utils, but the rosdep is failing from this package. This PR fixes the issue

Additional Context

@Jaeyoung-Lim
Copy link
Member Author

Jaeyoung-Lim commented May 20, 2021

@clanegge Could you share any insight whether the jenkins failure is a real failure?

gdal doesn't seem to be installed properly in the run_build.sh script(from the jenkins config) but I am not sure where to find the contents of the scripts.

@clanegge
Copy link
Contributor

Hi @Jaeyoung-Lim,

thanks for pointing that out. I suspect it has to do with the ros version with which the test is running (this build is using indigo and the last successful one was running with melodic). Otherwise i don't see what else has changed since then which would result in build failure. I will have a closer look next week and try to sort this out.

@Jaeyoung-Lim
Copy link
Member Author

@clanegge Hmm interesting. Thanks!

@clanegge
Copy link
Contributor

test this please

@ethzasl-jenkins
Copy link

Can one of the admins verify this patch?

@michaelpantic
Copy link
Member

ok to test

@michaelpantic
Copy link
Member

test this please

1 similar comment
@clanegge
Copy link
Contributor

test this please

@clanegge
Copy link
Contributor

clanegge commented Sep 9, 2021

Was fixed in #49 . Closing

@clanegge clanegge closed this Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rosdep installation for GDAL fails
4 participants