Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port mav_planning_rviz plugins to ROS 2 Humble #23

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

srmainwaring
Copy link
Collaborator

@srmainwaring srmainwaring commented Nov 15, 2023

Follow-up to #20. This updates the mav_planning_rviz plugins for ROS 2.

This version builds and runs, however there are currently issues with the interactive markers to resolve and a test environment running on a ROS 2 supported version of PX4 or ArduPilot is required (either using mavros for ROS 2 or preferably with DDS integration).

Dependencies

Tasks

@Ryanf55
Copy link
Contributor

Ryanf55 commented Nov 26, 2023

Follow-up to #20. This updates the mav_planning_rviz plugins for ROS 2.

This version builds and runs, however there are currently display issues to resolve and a test environment running on a ROS 2 supported version of PX4 or ArduPilot is required (either using mavros for ROS 2 or preferably with DDS integration).

Dependencies

Do you need me to test on mide side to see if the display issues are MacOS specific?

@srmainwaring
Copy link
Collaborator Author

Do you need me to test on mide side to see if the display issues are MacOS specific?

No, the display issues are now resolved. It’s a case of chasing down the service calls from each button to make sure they are running correctly with the correct inputs.

The most recent updates are in this branch: https://github.com/srmainwaring/terrain-navigation/tree/wips/wip-ap-dds-launch

@srmainwaring srmainwaring force-pushed the wips/wip-ros2-mav-rviz branch 4 times, most recently from 83bd047 to 3f218e8 Compare November 27, 2023 19:11
- Port goal_marker, edit_button, pose_widget.

Signed-off-by: Rhys Mainwaring <[email protected]>

- Port planning_interactive_markers.

Signed-off-by: Rhys Mainwaring <[email protected]>

- Partial port of planning_panel.

Signed-off-by: Rhys Mainwaring <[email protected]>

- Update service calls.

Signed-off-by: Rhys Mainwaring <[email protected]>

- Remove lib prefix from mav_planning_rviz plugin

Signed-off-by: Rhys Mainwaring <[email protected]>

- Use recommended ament install destinations

Signed-off-by: Rhys Mainwaring <[email protected]>

- Add python launch file for terrain_navigation_ros

Signed-off-by: Rhys Mainwaring <[email protected]>
@Jaeyoung-Lim Jaeyoung-Lim merged commit f16b3ad into ethz-asl:ros2 Nov 27, 2023
0 of 2 checks passed
@srmainwaring srmainwaring deleted the wips/wip-ros2-mav-rviz branch November 27, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants