Fix get Length #55
Merged
Fix get Length #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jaeyoung-Lim
force-pushed
the
pr-fix-get-length
branch
from
05c4ed1
to
f65e764
Compare
Jaeyoung-Lim
force-pushed
the
pr-fix-get-length
branch
from
f65e764
to
e59030f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description
There was an epsillion value that was used to handle periodic paths, which have the start and end of the segment very close.
Since we have an explicit flag of noting whether the path is periodic or not, we can use it to calculate it for the length information.
Related: #49