Refactor : Batch issuance rework #407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed from the Settings Screen the toggle for showing/hiding the batch issuance counter. Now it will always be visible, both in the Documents Tab and in the Document Details Screen. - Add Document Screen now has a data class where is config is parameterized, instead of a simple enum. - If Add Document Screen gets loaded with IssuanceFlowType.ExtraDocument and its FormatType is not null and matches some of the Issuer's supported documents, then only those documents will be displayed on its list. Existing functionality to also filter and show only the PIDs if the screen was loaded with IssuanceFlowType.NoDocument remains unchanged. - In the Documents Tab, if a document is running out of credentials (<=1 and its policy is OneTimeUse) then a warning icon will be displayed. - For the same scenario, in the Document Details Screen, the Credential Info section will be expanded by default (otherwise it will be collapsed) and it will also show a "Issue new" button(otherwise it will not be shown at all). Upon clicking it the User will be navigated to the Add Documents Screen with only this document displayed in its list. - getShowBatchIssuanceCounter() and setShowBatchIssuanceCounter() have been removed from the PrefKeys. All related strings, usages and dependencies have also been removed. - Navigation to the Add Document Screen has been updated and adjusted across the whole project. - Added new unit tests in the TestAddDocumentInteractor.kt to test these new changes. - Updated existing tests.
The `popUpToScreenRoute` and `inclusive` parameters in `Effect.Navigation.SwitchScreen` are now nullable. This allows navigation to the "Add Document" screen without popping the back stack. Specifically: - `popUpToScreenRoute` is now set to `null` when navigating to add a document. - `inclusive` is also set to `null` in this scenario. - The `DocumentDetailsScreen` now handles nullable `popUpToScreenRoute` and `inclusive` values in navigation effects.
The QR scan screen for an extra document issuance flow now navigates back (simple Pop) to the previous screen instead of popping to the Dashboard.
The footer in the AddDocumentScreen, which contains the 'Scan QR code' button and allows for scanning a Credential Offer, should be shown if no options(Documents that can be issued) are fetched from the Issuer's metadata (already existing logic that also shows it if the Issuance flow type is NoDocument remains unchanged.
stzouvaras
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor : Batch issuance rework
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: