Skip to content

MET-6562 Add User Dataset Drop-In #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jul 15, 2025
Merged

Conversation

andyjmaclean
Copy link
Contributor

No description provided.

@andyjmaclean andyjmaclean requested a review from jeortizquan July 3, 2025 16:01
Copy link
Contributor

@jeortizquan jeortizquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion, add blur filter background when showing the menu, so user knows where to focus.

afbeelding

to this
afbeelding

? 'drop-in-spinner'
: 'drop-in-cross';

return {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion to return an object containing the desired attributes (id,status,about,date)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion, add meaning to magic numbers 0, -1, 1, write a constant variable.

@andyjmaclean andyjmaclean merged commit e7651e2 into develop Jul 15, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants