MET-6977 Chained Rerun Design #959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeortizquan
approved these changes
Jan 5, 2026
Contributor
jeortizquan
left a comment
jeortizquan
left a comment
There was a problem hiding this comment.
a suggestion, see if this applies.
|
|
||
| isAncestorMode(): boolean { | ||
| return this.sandboxNavConf[2].stepSubClass === 'ancestor-mode'; | ||
| return (this.sandboxNavConf[2].stepSubClass ?? '').includes(this.ANCESTOR_MODE); |
Contributor
There was a problem hiding this comment.
suggestion this.sandboxNavConf[2] can be a variable to be accessed with a name? e.g.
this.sandboxNavConf[ITEM_NAME_BEING_ACCESSED] where const ITEM_NAME_BEING_ACCESSED=2
or
var navigationConfiguration = this.sandboxNavConf[2]
saying this from readability perspective when coming back and read the code we know what that 2 item means.
Contributor
Author
There was a problem hiding this comment.
You're right. I have plans to refactor this further in the future in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.