Switch to cmake #29
Open
Switch to cmake #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-7
to
+8
| build: | ||
| name: build | ||
| ubuntu: | ||
| name: Ubuntu |
There was a problem hiding this comment.
I think this change might break the build badge in the README?
There was a problem hiding this comment.
No, ubuntu is just an identifier for a job. There are now two jobs in the workflow:
jobs:
ubuntu:
...
macos:
...
You can see the result here:
https://github.com/rrrapha/keyfinder-cli/actions/runs/16602144524/job/46964467465
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make it easier to build and package keyfinder-cli on various platforms and operating systems.
The compile instructions are now the same as for libkeyfinder. The github workflow file has been updated to cover Ubuntu and macOS.
I've also tested this on OpenBSD. (There is already a package for OpenBSD, but the current version does not work on all platforms. Switching to cmake will probably fix the problem.)