Skip to content

Conversation

@harmendp
Copy link
Contributor

@harmendp harmendp commented Nov 3, 2025

Add minSoc & maxSoc params
Add maxdischargepower & use to reset register when returning to normal mode.
Change order of commands to set EMS mode last in stead of first when returning to normal mode.

harmendp and others added 4 commits November 3, 2025 21:03
Add maxdischargepower parameter to sungrow-hybrid meter template and implement its setting in the render section.
Change order of commands in the render section for sungrow-hybrid meter template to first set the EMS mode selection register before setting the max discharge power.
Added max charge/discharge power and state of charge parameters.
@andig
Copy link
Member

andig commented Nov 4, 2025

Add maxdischargepower & use to reset register when returning to hold mode.

Why do we need to fiddle with discharge power- because it's being set to 0?

@andig andig added the devices Specific device support label Nov 4, 2025
@harmendp
Copy link
Contributor Author

harmendp commented Nov 4, 2025

Add maxdischargepower & use to reset register when returning to hold mode.

Why do we need to fiddle with discharge power- because it's being set to 0?

Sorry, comment is wrong, must be 'normal' mode.

Current logic is wrong I believe. We set max discharge register to 10W in hold mode. When returning to normal mode, we need to reset it to a 'decent' value. Currently maxchargepower is used for this reset or when not set max reg value of 10.6kW. This max value is not accepted on my inverter (SH4.0RS, can only go to 6.5kW), so I'm forced to use maxchargepower. But this is one already used to limit max charge power from grid in charge mode.

@harmendp harmendp marked this pull request as ready for review November 4, 2025 18:49
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

advanced: true
- name: maxchargepower
help:
en: Maximum charge power for forced charging of the battery in watts. (0 to automatically set the value of the maximum BDC rated power)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does BCD rating happen?

- name: minsoc
default: 5
- name: maxsoc
default: 100
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need different defaults than other inverters?

@andig andig marked this pull request as draft November 7, 2025 14:58
Removed default values for minsoc and maxsoc.
@harmendp harmendp marked this pull request as ready for review November 7, 2025 18:40
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devices Specific device support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants