forecast: default to empty array

[Maschga]

Wenn die evcc Website für mehrere Tage ohne Neuladen angezeigt wird und in der Zwischenzeit z.B. GrünStromIndex nicht mehr erreichbar ist, kommt es zu dem Fehler, dass das Vorhersagemodel den Chart nicht mehr anzeigt.

Fehlermeldung im Log:

planner: cannot create tariff type 'template': cannot create tariff type 'grünstromindex': unexpected status: 429 (Too Many Requests)

Kamerabilder:

Toggle me!

Ich gehe davon aus, dass diese Zeilen das Problem sind, wenn nil zurückgegeben wird.

evcc/core/site_tariffs.go

Lines 103 to 114 in b928514

	fc := struct {
	Co2 api.Rates `json:"co2,omitempty"`
	FeedIn api.Rates `json:"feedin,omitempty"`
	Grid api.Rates `json:"grid,omitempty"`
	Planner api.Rates `json:"planner,omitempty"`
	Solar *solarDetails `json:"solar,omitempty"`
	}{
	Co2: tariff.Rates(site.GetTariff(api.TariffUsageCo2)),
	FeedIn: tariff.Rates(site.GetTariff(api.TariffUsageFeedIn)),
	Planner: tariff.Rates(site.GetTariff(api.TariffUsagePlanner)),
	Grid: tariff.Rates(site.GetTariff(api.TariffUsageGrid)),
	}

evcc/tariff/tariffs.go

Lines 34 to 45 in b928514

	func Rates(t api.Tariff) api.Rates {
	if t == nil {
	return nil
	}
	rr, err := t.Rates()
	if err != nil {
	return nil
	}
	return rr
	}

Deshalb habe ich api.Rates{} hinzugefügt.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

Prompt for AI Agents

Please address the comments from this code review:

## Individual Comments

### Comment 1
<location> `assets/js/components/Forecast/Chart.vue:61` </location>
<code_context>
-		grid: { type: Array as PropType<ForecastSlot[]> },
-		solar: { type: Object as PropType<SolarDetails> },
-		co2: { type: Array as PropType<ForecastSlot[]> },
+		grid: { type: Array as PropType<ForecastSlot[]>, default: [] },
+		solar: { type: Object as PropType<SolarDetails>, default: [] },
+		co2: { type: Array as PropType<ForecastSlot[]>, default: [] },
</code_context>

<issue_to_address>
**suggestion:** Consider using a factory function for default array values in props.

Use a factory function like `default: () => []` to prevent shared state between component instances.

Suggested implementation:

```
		grid: { type: Array as PropType<ForecastSlot[]>, default: () => [] },
		solar: { type: Object as PropType<SolarDetails>, default: () => ({}) },
		co2: { type: Array as PropType<ForecastSlot[]>, default: () => [] },

```

- If the default for `solar` should be `null` instead of an empty object, use `default: () => null` instead.
- Make sure that the default value for `solar` matches the expected shape of `SolarDetails` if you use an object.
</issue_to_address>

### Comment 2
<location> `assets/js/components/Forecast/Chart.vue:62` </location>
<code_context>
-		solar: { type: Object as PropType<SolarDetails> },
-		co2: { type: Array as PropType<ForecastSlot[]> },
+		grid: { type: Array as PropType<ForecastSlot[]>, default: [] },
+		solar: { type: Object as PropType<SolarDetails>, default: [] },
+		co2: { type: Array as PropType<ForecastSlot[]>, default: [] },
 		currency: { type: String as PropType<CURRENCY> },
</code_context>

<issue_to_address>
**issue (bug_risk):** Default value for object prop should be a factory function returning an object, not an array.

The `solar` prop's default value should be an object to match its type. Use `default: () => ({})` instead of an empty array to prevent type errors.
</issue_to_address>

### Comment 3
<location> `assets/js/components/Forecast/Chart.vue:63` </location>
<code_context>
-		co2: { type: Array as PropType<ForecastSlot[]> },
+		grid: { type: Array as PropType<ForecastSlot[]>, default: [] },
+		solar: { type: Object as PropType<SolarDetails>, default: [] },
+		co2: { type: Array as PropType<ForecastSlot[]>, default: [] },
 		currency: { type: String as PropType<CURRENCY> },
 		selected: { type: String as PropType<ForecastType> },
</code_context>

<issue_to_address>
**suggestion (bug_risk):** Use a factory function for array default values in props.

For consistency and to avoid shared state, use `default: () => []` for the `co2` prop, as with the `grid` prop.

```suggestion
		co2: { type: Array as PropType<ForecastSlot[]>, default: () => [] },
```
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[naltatis]

@Maschga Eigentlich sollten wir den Fall "es kommen keine Daten mehr" im Datenmodell und bei der Anzeige genau so behandeln wie den Fall dass schon vom Start an keine Daten vorhanden sind (bspw. kein CO2 konfiguriert). Machen wir hier im Publishing was anders?

Kurz: ich würd das Problem gerne an der Quelle adressieren.

[Maschga]

@naltatis Jetzt sollte im Backend immer api.Rates{} anstatt von nil zurückgegeben.
Aber im State wird nur forecast: {} angezeigt.
Weißt du warum? Was übersehe ich?