Skip to content

chore: npm deps, vite 8 upgrade, lightningcss#28183

Merged
andig merged 1 commit intomasterfrom
chore/vite8
Mar 14, 2026
Merged

chore: npm deps, vite 8 upgrade, lightningcss#28183
andig merged 1 commit intomasterfrom
chore/vite8

Conversation

@naltatis
Copy link
Member

📦 npm dependency upgrades
💫 using vite 8 (slight built time improvement: 8s > 7s)
🎨 new vite uses lightningcss, adds support for custom-media (no more hard coded breakpoints 🙌)
🐞 updated js color functions (css compatibility)
🗜️ generated assets are roughly the same size, rolldown generates more chunks eliminating the previous > 800kb warning.

@naltatis naltatis added the dependencies Pull requests that update a dependency file label Mar 13, 2026
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The new breakpoints.css is imported in multiple scoped component styles as well as in app.css; consider centralizing this import (e.g., only in a global entry stylesheet) to avoid duplicate CSS and reduce the risk of path/ordering issues across components.
  • The new setAlpha helper in colors.ts assumes 6- or 8-digit hex strings; if there’s any chance of receiving other CSS color formats (3/4-digit hex, rgb(), named colors), it might be safer to either sanitize/validate input or fail fast with a clearer behavior instead of returning the unmodified string.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The new breakpoints.css is imported in multiple scoped component styles as well as in app.css; consider centralizing this import (e.g., only in a global entry stylesheet) to avoid duplicate CSS and reduce the risk of path/ordering issues across components.
- The new setAlpha helper in colors.ts assumes 6- or 8-digit hex strings; if there’s any chance of receiving other CSS color formats (3/4-digit hex, rgb(), named colors), it might be safer to either sanitize/validate input or fail fast with a clearer behavior instead of returning the unmodified string.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@andig andig merged commit 661fd5f into master Mar 14, 2026
15 checks passed
@andig andig deleted the chore/vite8 branch March 14, 2026 10:43
@andig
Copy link
Member

andig commented Mar 14, 2026

Still contains an outdated dependency:

npm warn deprecated [email protected]: Old versions of glob are not supported, and contain widely publicized security vulnerabilities, which have been fixed in the current version. Please update. Support for old versions may be purchased (at exorbitant rates) by contacting [email protected]

@naltatis
Copy link
Member Author

Transient dev-dependency. Nothing we can do right now.

⎿  evcc@ /Users/michael/Lab/evcc
   └─┬ @vue/[email protected]
     └─┬ [email protected]
       └── [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants