Conversation
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The new breakpoints.css is imported in multiple scoped component styles as well as in app.css; consider centralizing this import (e.g., only in a global entry stylesheet) to avoid duplicate CSS and reduce the risk of path/ordering issues across components.
- The new setAlpha helper in colors.ts assumes 6- or 8-digit hex strings; if there’s any chance of receiving other CSS color formats (3/4-digit hex, rgb(), named colors), it might be safer to either sanitize/validate input or fail fast with a clearer behavior instead of returning the unmodified string.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new breakpoints.css is imported in multiple scoped component styles as well as in app.css; consider centralizing this import (e.g., only in a global entry stylesheet) to avoid duplicate CSS and reduce the risk of path/ordering issues across components.
- The new setAlpha helper in colors.ts assumes 6- or 8-digit hex strings; if there’s any chance of receiving other CSS color formats (3/4-digit hex, rgb(), named colors), it might be safer to either sanitize/validate input or fail fast with a clearer behavior instead of returning the unmodified string.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Member
|
Still contains an outdated dependency: |
Member
Author
|
Transient dev-dependency. Nothing we can do right now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📦 npm dependency upgrades
💫 using vite 8 (slight built time improvement: 8s > 7s)
🎨 new vite uses lightningcss, adds support for custom-media (no more hard coded breakpoints 🙌)
🐞 updated js color functions (css compatibility)
🗜️ generated assets are roughly the same size, rolldown generates more chunks eliminating the previous
> 800kbwarning.