-
Notifications
You must be signed in to change notification settings - Fork 624
[Improvement] Update Broken UI for "Employee/Team" Column in Project List View (#8539) #8898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
samuelmbabhazi
wants to merge
6
commits into
develop
Choose a base branch
from
fix/8539-project-list-employee-team-column-ui
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
4b46dac
fix(project-list): update broken UI for "Employee/Team" column
samuelmbabhazi 552fef0
refactor design
samuelmbabhazi 10379fa
change max display
samuelmbabhazi 277ee91
fix Cspell
samuelmbabhazi e4b60ca
feedback integration
samuelmbabhazi e521c8b
feedback integration
samuelmbabhazi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
51 changes: 23 additions & 28 deletions
51
...re/shared/src/lib/table-components/employee-with-links/employee-with-links.component.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,32 +1,27 @@ | ||
<div class="main"> | ||
<ng-container *ngFor="let groups of employees"> | ||
<div *ngIf="value" class="avatar-container"> | ||
<div class="avatar-group"> | ||
<ng-container *ngFor="let employee of groups; let i = index"> | ||
<a | ||
class="avatar" | ||
*ngIf="employee?.user" | ||
(click)=" | ||
selectEmployee( | ||
employee, | ||
employee.user.firstName, | ||
employee.user.lastName, | ||
employee.user.imageUrl | ||
) | ||
" | ||
> | ||
<img | ||
class="img" | ||
type="user" | ||
[src]="employee.user.imageUrl" | ||
/> | ||
<span | ||
>{{ employee.user.firstName }} | ||
{{ employee.user.lastName }}</span | ||
> | ||
</a> | ||
</ng-container> | ||
<div *ngIf="value" class="avatar-container"> | ||
<div class="avatar-group"> | ||
<ng-container *ngFor="let employee of displayedEmployees"> | ||
<a | ||
class="avatar" | ||
*ngIf="employee?.user" | ||
(click)=" | ||
selectEmployee( | ||
employee, | ||
employee.user.firstName, | ||
employee.user.lastName, | ||
employee.user.imageUrl | ||
) | ||
" | ||
> | ||
<img class="img" type="user" [src]="employee.user.imageUrl" /> | ||
<span>{{ employee.user.firstName }} {{ employee.user.lastName }}</span> | ||
</a> | ||
</ng-container> | ||
|
||
<div *ngIf="remainingCount > 0" class="remaining-count"> | ||
<span>+{{ remainingCount }}</span> | ||
</div> | ||
</div> | ||
</ng-container> | ||
</div> | ||
</div> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.