-
Notifications
You must be signed in to change notification settings - Fork 646
Merge pull request #9068 from ever-co/fix/mcp-electron-build #9069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[Fix] Fix build errors issues for MCP server electron desktop app
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Summary
This PR fixes build errors for the MCP (Model Context Protocol) server electron desktop app through configuration adjustments and build pipeline integration. The MCP server is a new component in the Ever Gauzy platform that enables desktop app functionality through the Model Context Protocol.
The changes address three key areas:
-
Package Configuration: The MCP server's
package.json
is updated to usemain.js
as the entry point instead ofindex.js
, and the problematic@gauzy/config
dependency is removed from both workspaces and dependencies to eliminate build conflicts. -
Build Pipeline Integration: The root
package.json
is modified to include MCP server builds in the comprehensive build scripts (build:package:all
,build:package:all:prod
,build:package:all:docker
) and adds a new Docker-specific build command. A minor spacing fix is also applied to prevent syntax errors. -
TypeScript Configuration: The
tsconfig.electron.json
is restructured to properly inherit from the base configuration, removes conflicting electron type definitions, updates the module system to ES2022, and adjusts include paths to match the MCP server's unique entry point structure.
These changes follow established patterns in the codebase where desktop applications are configured with specific entry points and build configurations, while ensuring the MCP server integrates seamlessly with the overall build system.
PR Description Notes:
- The PR template checkboxes are not checked, which violates the contributing guidelines
- The description lacks explanation of what the changes do and why they add value
Confidence score: 3/5
- This PR appears to address legitimate build configuration issues but has some concerning aspects that require attention.
- The removal of
@gauzy/config
dependency could potentially break functionality if the main.js file still relies on configuration from that package, and there's insufficient context to verify this won't cause runtime issues. - The following files need more attention:
apps/server-mcp/src/package.json
(due to dependency removal),apps/server-mcp/tsconfig.electron.json
(configuration inheritance changes)
3 files reviewed, no comments
[Fix] Fix build errors issues for MCP server electron desktop app
PR
Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.