-
Notifications
You must be signed in to change notification settings - Fork 212
build(deps): bump axios from 1.7.7 to 1.8.2 #478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bumps [axios](https://github.com/axios/axios) from 1.7.7 to 1.8.2. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v1.7.7...v1.8.2) --- updated-dependencies: - dependency-name: axios dependency-version: 1.8.2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Join our Discord community for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR updates axios from v1.7.7 to v1.8.2 in the ever-traduora project, introducing a new feature for handling absolute URLs and fixing several bugs.
- Added
allowAbsoluteUrls
config option in http-adapter for path building - Moved
generateString
utility to platform utils to avoid importing crypto module in client builds - BREAKING CHANGE: URLs will now be combined instead of preferring request URL by default
- Project uses axios in API layer for authentication and requests, so testing URL handling changes is recommended
- Requires Node.js >=18.0.0 as specified in package.json engine requirements
No file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
@samuelmbabhazi can you check if we can do such update of axios package and all still working (including tests?). Also make sure you explicitly updated it in package.json, not only in lock file and update this PR with that |
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
Based on the provided information and focusing on the most recent changes, here's my analysis of the axios update:
The axios update to v1.8.2 introduces important changes to URL handling in the ever-traduora API layer.
- Review
api/src/services/auth.service.ts
for potential URL handling issues with Google OAuth endpoints - Check
api/src/controllers/auth.controller.ts
andapi/src/controllers/translation.controller.ts
for absolute URL usage in API requests - Consider adding explicit
allowAbsoluteUrls
config in axios instances where absolute URLs are needed - Test authentication flows thoroughly as they rely heavily on URL handling for external providers
- Ensure
config.providers.google.apiUrl
and other absolute URLs work correctly with the new URL combining behavior
The focus should be on testing authentication and external API integrations since they are most likely to be affected by the URL handling changes.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Bumps axios from 1.7.7 to 1.8.2.
Release notes
Sourced from axios's releases.
... (truncated)
Changelog
Sourced from axios's changelog.
... (truncated)
Commits
a9f7689
chore(release): v1.8.2 (#6812)fb8eec2
fix(http-adapter): add allowAbsoluteUrls to path building (#6810)9812045
chore(sponsor): update sponsor block (#6804)72acf75
chore(sponsor): update sponsor block (#6794)2e64afd
chore(release): v1.8.1 (#6800)36a5a62
fix(utils): movegenerateString
to platform utils to avoid importing crypto...cceb7b1
chore(release): v1.8.0 (#6795)23a25af
fix(utils): replace getRandomValues with crypto module (#6788)32c7bcc
feat: Add config for ignoring absolute URLs (#5902) (#6192)4a3e26c
chore(config): adjust rollup config to preserve license header to minified Ja...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.