Feature: function to update locations.json #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- called whenever generate_locations_md.py is ran - added encoder to match format of original locations.json
jimjimrao
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add functionality to update
locations.jsonwhengenerate_locations_md.pyis ranChanges Made
CompactEncoderclass for custom JSON encoding to be similar to original locations.jsonoutput_to_jsonfunction to write locations data to a JSON fileget_locationsfunction to calloutput_to_jsonTesting
I ran the
utils/generate_locations_md.pyscript, which successfully generated a newutils/locations.jsonfile containing the updated location data.Screenshots
The diff without considering white spaces looks like this:
