Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Suppress OCSP warnings in Snowflake Connector" #2639

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

zachstence
Copy link
Member

@zachstence zachstence commented Oct 10, 2024

Reverts #2631

According to the Snowflake team here snowflakedb/snowflake-connector-nodejs#932 (comment)

which we, as Snowflake, generally don't really recommend to do as a permanent 'solution' but here the cert chain cannot fully be validated anyways, so...

Using insecureConnect is not a recommended long-term solution.

I don't want Evidence opening security holes just to quiet a noisy log. The noisy log can stay until we find a way to quiet the log without impacting security, or until the OCSP issue is fixed within Snowflake.

@zachstence zachstence self-assigned this Oct 10, 2024
Copy link

changeset-bot bot commented Oct 10, 2024

⚠️ No Changeset found

Latest commit: 2e4f190

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 5:09pm
next-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 5:09pm

Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for evidence-development-workspace ready!

Name Link
🔨 Latest commit 2e4f190
🔍 Latest deploy log https://app.netlify.com/sites/evidence-development-workspace/deploys/670807b5ad07520007cb23b2
😎 Deploy Preview https://deploy-preview-2639--evidence-development-workspace.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for next-docs-evidence ready!

Name Link
🔨 Latest commit 2e4f190
🔍 Latest deploy log https://app.netlify.com/sites/next-docs-evidence/deploys/670807b5d348ff0008a18d49
😎 Deploy Preview https://deploy-preview-2639--next-docs-evidence.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for evidence-test-env ready!

Name Link
🔨 Latest commit 2e4f190
🔍 Latest deploy log https://app.netlify.com/sites/evidence-test-env/deploys/670807b5d548e50008f1a38d
😎 Deploy Preview https://deploy-preview-2639--evidence-test-env.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@zachstence zachstence force-pushed the revert-2631-snowflake-suppress-ocsp-logs branch from c11997b to 7d441ec Compare October 10, 2024 16:52
@zachstence zachstence merged commit 1632294 into next Oct 10, 2024
19 checks passed
@zachstence zachstence deleted the revert-2631-snowflake-suppress-ocsp-logs branch October 10, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants