Skip to content

tech: maintenance #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 23, 2025
Merged

tech: maintenance #979

merged 3 commits into from
Apr 23, 2025

Conversation

ala-n
Copy link
Contributor

@ala-n ala-n commented Apr 23, 2025

No description provided.

@ala-n ala-n self-assigned this Apr 23, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR is focused on maintenance improvements across configuration and core plugin files. Key changes include:

  • Simplifying method implementations and adding missing semicolons.
  • Updating import syntax to leverage type-only imports.
  • Consolidating and migrating configuration files for PostCSS, ESLint, and Stylelint.

Reviewed Changes

Copilot reviewed 10 out of 17 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/plugins/settings/base-setting/base-setting.ts Removed unnecessary return statement in an empty method implementation
src/plugins/reset/reset-button.ts Refactored import of UIPRoot to a type-only import
src/core/base/state.storage.ts Added semicolons to ensure consistency in method calls
site/postcss.config.cjs Newly added PostCSS configuration file
postcss.config.cjs Removed duplicate PostCSS configuration file
eslint.config.mjs Added new ESLint configuration based on shared ESL guidelines
eslint.config.js Removed legacy ESLint configuration
eslint.config.ignore.js Removed legacy ESLint ignore configuration
.stylelintrc.yml Simplified Stylelint configuration by extending a shared config
Files not reviewed (7)
  • .browserslistrc: Language not supported
  • .prettierignore: Language not supported
  • .prettierrc.yml: Language not supported
  • package.json: Language not supported
  • site/package.json: Language not supported
  • src/plugins/editor/editor.less: Language not supported
  • src/plugins/settings/settings.less: Language not supported

@ala-n ala-n merged commit cebbd5e into main Apr 23, 2025
4 checks passed
@ala-n ala-n deleted the tech/maitanance branch April 23, 2025 17:47
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants