Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/interval ratio 3digit precision #56

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bishibashiB
Copy link

@bishibashiB bishibashiB commented Nov 21, 2021

HI!
Awesome add-on... using it a lot lately. ... here is a thing about I like to improve the interval settings.
Maybe you can kindly hint me to any test procedure to validate the PR~,

Itentions:

  • 1st change I interpret there is a bug in the interval_ration option as - for odd number of tabs - is multiplied twice (also line 43,44)
  • 2nd change: For me i had a total length of 18cm and wanted to have 7-8 tabs on it. limiting the ratio to 2 decimals did not allow me to get results in a accuracy of 0.2mm (1% of 18cm) which adds up to around 2mm after the 10th tab.

@luzpaz
Copy link
Contributor

luzpaz commented Dec 10, 2021

@bishibashiB you can click on the line number in the code and copy/paste the URL so it's more convenient to see the code you're referring to.

CC @execuc have you seen this PR?

@luzpaz
Copy link
Contributor

luzpaz commented Jan 19, 2022

Ping @execuc are you still maintaining this freecad workbench?

@luzpaz
Copy link
Contributor

luzpaz commented Mar 6, 2023

bump @execuc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants