-
-
Notifications
You must be signed in to change notification settings - Fork 367
idris uses slug #1192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
idris uses slug #1192
Conversation
When testing in a shell,
achieves what we need, as we have |
cc @ErikSchierboom from idris track-maintainers |
@keiravillekode Thanks! The gist of it looks good, except for the part where it infers the slug from the directory name. Technically, the better way to do that would be to read the config file (I think |
Updated. It is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last comment
@@ -101,3 +101,43 @@ func TestRustHasTrailingDashes(t *testing.T) { | |||
|
|||
assert.True(t, strings.HasSuffix(cmd, "--"), "rust's test command should have trailing dashes") | |||
} | |||
|
|||
func TestIdrisUsesCurrentDirectory(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
func TestIdrisUsesCurrentDirectory(t *testing.T) { | |
func TestIdrisUsesExerciseSlug(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll probably have to do a release later this week
@keiravillekode Would you mind also updating the documentation here: https://github.com/exercism/docs/blob/main/building/tooling/cli.md#test-command-placeholders? |
If you are doing a release, perhaps #1193 can be included. |
I've released a new version |
No description provided.