Skip to content

idris uses slug #1192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 27, 2025
Merged

Conversation

keiravillekode
Copy link
Contributor

No description provided.

@keiravillekode
Copy link
Contributor Author

When testing in a shell,

    pack test `basename *.ipkg .ipkg`

achieves what we need, as we have hello-world.ipkg

@keiravillekode
Copy link
Contributor Author

cc @ErikSchierboom from idris track-maintainers

@ErikSchierboom
Copy link
Member

@keiravillekode Thanks! The gist of it looks good, except for the part where it infers the slug from the directory name. Technically, the better way to do that would be to read the config file (I think exercism.json) in the directory.

@keiravillekode
Copy link
Contributor Author

@keiravillekode Thanks! The gist of it looks good, except for the part where it infers the slug from the directory name. Technically, the better way to do that would be to read the config file (I think exercism.json) in the directory.

Updated. It is .exercism/metadata.json , which ExerciseMetadata reads (and writes in tests).

Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last comment

@@ -101,3 +101,43 @@ func TestRustHasTrailingDashes(t *testing.T) {

assert.True(t, strings.HasSuffix(cmd, "--"), "rust's test command should have trailing dashes")
}

func TestIdrisUsesCurrentDirectory(t *testing.T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
func TestIdrisUsesCurrentDirectory(t *testing.T) {
func TestIdrisUsesExerciseSlug(t *testing.T) {

Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll probably have to do a release later this week

@ErikSchierboom
Copy link
Member

@ErikSchierboom ErikSchierboom merged commit 4a57aa7 into exercism:main May 27, 2025
7 checks passed
@keiravillekode keiravillekode deleted the idris-uses-slug branch May 27, 2025 07:36
@keiravillekode
Copy link
Contributor Author

If you are doing a release, perhaps #1193 can be included.

@ErikSchierboom
Copy link
Member

I've released a new version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants