Skip to content

Use mode 0700 for the config dir, not 0755; other users should not have access #1210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2025
Merged

Use mode 0700 for the config dir, not 0755; other users should not have access #1210

merged 1 commit into from
Aug 31, 2025

Conversation

IsaacG
Copy link
Member

@IsaacG IsaacG commented Aug 16, 2025

No description provided.

@IsaacG
Copy link
Member Author

IsaacG commented Aug 16, 2025

See forum thread

iHiD
iHiD approved these changes Aug 31, 2025
View reviewed changes
Copy link
Member

@iHiD iHiD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presuming this has been tested manually, I'm 👍 Thanks!

@SleeplessByte SleeplessByte added x:action/fix Fix an issue x:type/coding Write code that is not student-facing content (e.g. test-runners, generators, but not exercises) x:size/small Small amount of work labels Aug 31, 2025
SleeplessByte
SleeplessByte approved these changes Aug 31, 2025
View reviewed changes
Copy link
Member

@SleeplessByte SleeplessByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yah I think this is correct but please try it out first 😬

@IsaacG
Copy link
Member Author

IsaacG commented Aug 31, 2025 

» rm -rf /home/goodi/.xdg/config/testercism

» ./testercism configure --token=$token

You have configured the Exercism command-line client:

Config dir:                       /home/goodi/.xdg/config/testercism
Token:         (-t, --token)      <$TOKEN>
Workspace:     (-w, --workspace)  /home/goodi/testercism
API Base URL:  (-a, --api)        https://api.exercism.org/v1

» ls -ld /home/goodi/.xdg/config/testercism
drwx------ 2 goodi goodi 4096 Aug 31 08:05 /home/goodi/.xdg/config/testercism

Testing: run the command to create a new config dir. The resulting dir has mode 0700.

@IsaacG IsaacG merged commit c1fb103 into exercism:main Aug 31, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iHiD iHiD iHiD approved these changes

@SleeplessByte SleeplessByte SleeplessByte approved these changes

+3 more reviewers

@kotp kotp kotp approved these changes

@BNAndras BNAndras BNAndras approved these changes

@keiravillekode keiravillekode keiravillekode approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
x:action/fix Fix an issue x:size/small Small amount of work x:type/coding Write code that is not student-facing content (e.g. test-runners, generators, but not exercises)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@IsaacG @kotp @iHiD @SleeplessByte @BNAndras @keiravillekode