Rewrite the Simple Cipher description. #2565
Open
+27
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See [forum discussion](https://forum.exercism.org/t/simple-cipher-change-proposal-rewrite-the-description/17380] Key improvements: * Remove mentions of "Steps" and "Extension". * Replace "Caeser cipher" with "Vigenère cipher" to accurately match what is being asked. * Use a format in line with the other cipher exercises.
BNAndras
approved these changes
May 15, 2025
Co-authored-by: András B Nagy <[email protected]>
BNAndras
reviewed
May 15, 2025
…the/implementation of the/ Co-authored-by: András B Nagy <[email protected]>
ErikSchierboom
approved these changes
May 15, 2025
tasxatzial
reviewed
May 15, 2025
|
metadata.toml also needs to be updated |
Good catch! I completely missed that. Fixed. |
tasxatzial
reviewed
May 16, 2025
| They are vulnerable to many forms of cryptanalysis, but Caesar was lucky that his enemies were not cryptanalysts. | ||
| In a _substitution cipher_, each plaintext letter is replaced with a ciphertext letter which is computed with the help of a _key_. | ||
| (Note, it is possible for replacement letter to be the same as the original letter! | ||
| As mentioned earlier, an `"a"` in the key means there is no shift/change.) |
There was a problem hiding this comment.
This is a detail mentioned later rather than earlier. I think it's safe to remove this sentence, since the explanation comes a couple of sentences later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See forum discussion
Key improvements:
what is being asked.