Open
Conversation
atk
requested changes
Jun 30, 2025
Contributor
atk
left a comment
atk
left a comment
There was a problem hiding this comment.
Please at least consider making the tests more maintainable even if you insist on keeping the input format.
|
|
||
| ## Input format | ||
|
|
||
| Each stone is represented in a single byte: 4 bits for each half. |
Contributor
There was a problem hiding this comment.
According to Wikipedia, there are also extended domino sets that go up to 1-18, which would be more than can be represented in a nibble, even if you started at 0.
Wouldn't it make more sense to use 2xu8 for each stone?
| }); | ||
|
|
||
| xtest("singleton input = singleton output", () => { | ||
| expect(canChain("\x11")).toBe(1); |
Contributor
There was a problem hiding this comment.
It would be better to have some automatic conversion so is is easier to read and maintain these tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #167