Detect XR usage #1379
Open
Detect XR usage #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a long time Exokit relied on the parent site knowing whether to open a Reality Tab in a 2D or 3D context, but this was one of the most common user mistakes in our UIs.
This PR attempts to implement an "XR autodetect" on the first Window tick of a reality tab, emitting an
xrModeevent on theHTMLIframeElement. With this, Exokit browser frontends can rely on a more automatic instantiation of reality tabs by first attempting the common 3D case and -- failing that -- falling back to the 2D browser plane implementation.