MAINT: Baseline setup for free-threading #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Subsumed the typo PR #48 into this one |
Closed
rgommers
requested changes
May 23, 2025
There was a problem hiding this comment.
Thanks @HaoZeke. Looks largely right. A few small comments.
Also note that the cibuildwheel version needs bumping to the latest released version or the enable = part won't work, here:
cymem/.github/workflows/cibuildwheel.yml
Line 22 in a66af97
| self.matrices = <SparseMatrix**>self.mem.alloc(self.length, sizeof(SparseMatrix*)) | ||
| for i, py_matrix in enumerate(py_matrices): | ||
| self.matrices[i] = sparse_matrix_init(self.mem, py_matrix) | ||
| self.matrices[i] = sparse_matrix_init_cymem(self.mem, py_matrix) |
There was a problem hiding this comment.
It's minor, but this would have been better left as a separate PR, since it's unrelated to the topic of this PR, trivial to review/merge, and after that CI will run on this PR without approval.
Part of the next PR...
Co-authored-by: rgommers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements (1) as suggested by @rgommers in #47 (comment). Basically builds without a warning, but isn't really safe.