fix: add prefix check to prevent unwanted error message#4
Merged
nfriedly merged 1 commit intoexpress-rate-limit:mainfrom May 29, 2024
Merged
Conversation
added prefix check on onMessage handler of ClusterMemoryStoreWorker to prevent Error: ClusterMemoryStoreWorker:1: response recieved without matching open request when using multiple instences of ClusterMemoryStoreWorker Closes express-rate-limit#3
nfriedly
approved these changes
May 29, 2024
Member
nfriedly
left a comment
nfriedly
left a comment
There was a problem hiding this comment.
Oh, that is simpler than the fix I had in mind. I think we'll go with your version. Thanks!
Member
|
Ok, it should get released to npm as v0.2.1 shortly. Thanks again! |
Member
|
FYI, I'm also adding npm package provenance support to the release process and publishing that as v0.3.0. (I thought of it right after releasing v0.2.1 or I would have published them together.) I just wanted to clarify that since they're coming out so close together. |
Author
|
Great, Thanks for your quick support. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added prefix check on onMessage handler of
ClusterMemoryStoreWorkerto preventError: ClusterMemoryStoreWorker:1: response recieved without matching open requestwhen using multiple instences ofClusterMemoryStoreWorkerCloses #3