feat: add upgrade command #8
Conversation
bjohansebas
force-pushed
the
update-command
branch
2 times, most recently
from
d83aa6a to
b29fcef
Compare
bjohansebas
force-pushed
the
update-command
branch
from
b29fcef to
240999d
Compare
bjohansebas
force-pushed
the
update-command
branch
from
31a6d97 to
b988b75
Compare
|
@kjugi What do you think of the messages I added to the upgrade command? It no longer uses the jscodeshift output, although I think it's a bit confusing, the statistics output adds up the files in each loop. |
| console.info('> Cancelled process. Program will stop now without any actions. \n') | ||
| process.exit(1) | ||
| } | ||
| import { onCancel, promptSource } from '../utils/share' |
There was a problem hiding this comment.
this share filename needs adjustment. It does not tell what can be found inside. From what I can see you collect there utility methods for commands
There was a problem hiding this comment.
Yeah, I gave it that name without thinking too much, I just wanted to separate it
| const expressVersion = coerce(dependencies.express)?.version ?? '4.0.0' | ||
|
|
||
| const codemodsSuggested = TRANSFORM_OPTIONS.filter((a) => { | ||
| return compare(a.version, expressVersion) > 0 |
There was a problem hiding this comment.
shouldn't we apply our codemods only if the project is on v4?
according to docs:
compare(v1, v2): Return 0 if v1 == v2, or 1 if v1 is greater, or -1 if v2 is greater.
There was a problem hiding this comment.
It is more thought out so that in the future more codemods can be added as Express evolves, and not limit us to version 4
commands/upgrade.ts
Outdated
| { | ||
| type: 'multiselect', | ||
| name: 'codemodsSelected', | ||
| message: `The following 'codemods' are recommended for your upgrade. Select the ones to apply.`, |
There was a problem hiding this comment.
we recommend them only by checking version in the package.json file. It doesn't necessarily bring value. Let's just check if express is there and ask user to select codemods.
There was a problem hiding this comment.
But what if there are codemods for version 6 and we're on version 5? We wouldn't want to recommend codemods from version 4, right?
commands/upgrade.ts
Outdated
| console.log(`> ${results.ok} codemods were applied successfully`) | ||
| console.log(`> ${results.skipped} codemods were skipped`) | ||
| console.log(`> ${results.failed} codemods failed`) | ||
| console.log(`> ${results.unmodified} codemods were skipped because they didn't change anything`) |
There was a problem hiding this comment.
|
I'm going to keep doing this next year, @kjugi if you want to keep going with it, it's okay by me. |
This adds the command to update Express in a single step, displaying the available options based on the version specified in the package.json.
Things still to do: