Skip to content

deps: improve package dependencies using caret (^) #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2025
Merged

deps: improve package dependencies using caret (^) #214

merged 1 commit into from
Apr 14, 2025

Conversation

bjohansebas
Copy link
Member

@bjohansebas bjohansebas changed the title fix(ci): improve package dependencies using caret (^) deps: improve package dependencies using caret (^) Jan 16, 2025
@socket-security Socket Security
Copy link

socket-security bot commented Jan 16, 2025 •
edited
Loading

New and updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] ➜ 2.31.0 environment Transitive: eval +115 6.64 MB ljharb
npm/[email protected] ➜ 6.3.4 Transitive: environment, eval, filesystem +40 1.93 MB titanism

View full report↗︎

@bjohansebas bjohansebas force-pushed the dependencies-caret branch 2 times, most recently from 4bf32be to e5e4e59 Compare January 16, 2025 19:40
@bjohansebas bjohansebas mentioned this pull request Jan 16, 2025
Closed
wesleytodd
wesleytodd requested changes Jan 16, 2025
View reviewed changes
Copy link
Member

@wesleytodd wesleytodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think we should apply this change until we major rev and drop the old node versions.

@bjohansebas
Copy link
Member Author

Then document it in the RFC/ADR. I had asked if the way forward was to update the CI or wait until we drop support for the old Node versions.

@wesleytodd wesleytodd mentioned this pull request Jan 16, 2025
Merged
@Phillip9587 Phillip9587 added this to the 2.0 milestone Feb 11, 2025
@bjohansebas bjohansebas changed the base branch from master to v2 February 14, 2025 21:39
@bjohansebas bjohansebas requested a review from wesleytodd April 7, 2025 17:24
@bjohansebas
Copy link
Member Author

We no longer support older versions, so this can be reviewed again. Ideally, it would go into version 2.

@bjohansebas bjohansebas merged commit f1b3e1c into expressjs:v2 Apr 14, 2025
16 checks passed
@bjohansebas bjohansebas deleted the dependencies-caret branch April 14, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleytodd wesleytodd wesleytodd approved these changes

@UlisesGascon UlisesGascon Awaiting requested review from UlisesGascon

Assignees
No one assigned
Labels
semver-major
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bjohansebas @wesleytodd @Phillip9587