Skip to content

feat(blog): 5.1.0 release blog #1849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Mar 31, 2025
Merged

feat(blog): 5.1.0 release blog #1849

merged 19 commits into from
Mar 31, 2025

Conversation

wesleytodd
Copy link
Member

@wesleytodd wesleytodd commented Mar 29, 2025 •
edited
Loading

@wesleytodd wesleytodd requested a review from a team as a code owner March 29, 2025 17:54
@netlify Netlify
Copy link

netlify bot commented Mar 29, 2025 •
edited
Loading

✅ Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit 925ba32
🔍 Latest deploy log https://app.netlify.com/sites/expressjscom-preview/deploys/67ea9f74c5708e0008022610
😎 Deploy Preview https://deploy-preview-1849--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@wesleytodd wesleytodd mentioned this pull request Mar 29, 2025
Merged
@bjohansebas bjohansebas mentioned this pull request Mar 29, 2025
Closed
@bjohansebas bjohansebas requested a review from a team March 29, 2025 18:11
@bjohansebas bjohansebas linked an issue Mar 29, 2025 that may be closed by this pull request
Blog about the codemods #1825
Closed
ShubhamOulkar
ShubhamOulkar reviewed Mar 29, 2025
View reviewed changes
Copy link
Member

@ShubhamOulkar ShubhamOulkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should start blog with our new updates in api and bug fixes. Then migration topics so on .... and @ last thanks for contributors. 🤔?

@ShubhamOulkar
Copy link
Member

Need fix in markdown file 👨‍🔧

Use markdown url syntax for pr's

content overflow on mobile devices
Screenshot_20250330-003808_Chrome Screenshot_20250330-003613_Chrome Screenshot_20250330-003815_Chrome

UlisesGascon
UlisesGascon reviewed Mar 29, 2025
View reviewed changes
Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking very good! I just a added a bunch of suggestions 😉

naugtur
naugtur reviewed Mar 29, 2025
View reviewed changes
_posts/2025-01-09-v5-1-latest-release.md Outdated

* Transitioned all remaining dependencies to use `^` ranges instead of locked versions
* Add package.json funding field to highlight our OpenCollective
* Added support for ETag option in `res.sendFile()`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@bjohansebas bjohansebas mentioned this pull request Mar 30, 2025
Merged
wesleytodd and others added 10 commits March 30, 2025 09:37
@wesleytodd @naugtur
Update _posts/2025-01-09-v5-1-latest-release.md
32c07b3 
Co-authored-by: Zbyszek Tenerowicz <[email protected]>
@wesleytodd @UlisesGascon
Update _posts/2025-01-09-v5-1-latest-release.md
cbd6e7c 
Co-authored-by: Ulises Gascón <[email protected]>
@wesleytodd @UlisesGascon
Update _posts/2025-01-09-v5-1-latest-release.md
d90ed71 
Co-authored-by: Ulises Gascón <[email protected]>
@wesleytodd @UlisesGascon
Update _posts/2025-01-09-v5-1-latest-release.md
66ab554 
Co-authored-by: Ulises Gascón <[email protected]>
@wesleytodd @UlisesGascon
Update _posts/2025-01-09-v5-1-latest-release.md
b745921 
Co-authored-by: Ulises Gascón <[email protected]>
@wesleytodd @UlisesGascon
Update _posts/2025-01-09-v5-1-latest-release.md
2b5fcb7 
Co-authored-by: Ulises Gascón <[email protected]>
@wesleytodd @UlisesGascon
Update _posts/2025-01-09-v5-1-latest-release.md
a2922d1 
Co-authored-by: Ulises Gascón <[email protected]>
@wesleytodd @UlisesGascon
Update _posts/2025-01-09-v5-1-latest-release.md
939447d 
Co-authored-by: Ulises Gascón <[email protected]>
@wesleytodd @bjohansebas
Update _posts/2025-01-09-v5-1-latest-release.md
f63ac39 
Co-authored-by: Sebastian Beltran <[email protected]>
@wesleytodd @UlisesGascon
Update _posts/2025-01-09-v5-1-latest-release.md
fa4448a 
Co-authored-by: Ulises Gascón <[email protected]>
UlisesGascon
UlisesGascon approved these changes Mar 30, 2025
View reviewed changes
Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Looks very solid now.

Just a minor suggestion @wesleytodd: We might want to relocate the thanks paragraph as currently "feels" like is related to the documentation only. We can add it as second paragraph or as the last piece of the article as an alternative.

image

bjohansebas
bjohansebas approved these changes Mar 31, 2025
View reviewed changes
Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Remember to change the publication date. If you need help with that, let me know and I’ll make the change.

@bjohansebas bjohansebas requested review from a team as code owners March 31, 2025 02:17
@bjohansebas
Copy link
Member

My last commit was to slightly fix the mobile responsiveness of the table since, as reported by @ShubhamOulkar, it was causing horizontal scrolling on mobile devices.

@expressjs/docs-wg, we need to investigate how to improve the mobile responsiveness of tables.

Since this blog is being launched very soon, I didn’t want the content to look bad on mobile, so I went ahead and made the commit here. Any suggestions on how to fix it can be discussed in a future issue.

@ShubhamOulkar
Copy link
Member

ShubhamOulkar commented Mar 31, 2025 •
edited
Loading

My last commit was to slightly fix the mobile responsiveness of the table since, as reported by @ShubhamOulkar, it was causing horizontal scrolling on mobile devices.

Yup, last commit slightly fix horizontal scroll. Now table is causing small shift in layout. But now not breaking or shifting is noticeable on small screens.

Note: all tables on website need fix. See #1831

@wesleytodd
Copy link
Member Author

Looks like all the feedback has been addressed. I am going review anything remaining on the LTS ADR and then get to publishing the release. Thanks everyone, truly a great team effort.

@wesleytodd
Copy link
Member Author

Ah, I just realized that we did not link to the original v5 release blog, which contains a lot of the breaking information folks will need. Adding a link to that in the migration section.

@wesleytodd wesleytodd merged commit 586b428 into gh-pages Mar 31, 2025
7 checks passed
@bjohansebas bjohansebas deleted the 5-1-0-blog branch March 31, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naugtur naugtur naugtur left review comments

@ShubhamOulkar ShubhamOulkar ShubhamOulkar left review comments

@bjohansebas bjohansebas bjohansebas approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@jonchurch jonchurch jonchurch approved these changes

@Phillip9587 Phillip9587 Phillip9587 approved these changes

Assignees
No one assigned
Labels
blog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Blog about the codemods
7 participants
@wesleytodd @ShubhamOulkar @bjohansebas @naugtur @UlisesGascon @jonchurch @Phillip9587