Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "feat: conditionally set headers (if not already set) in redirect response (#190)" #200

Merged
merged 1 commit into from
Mar 27, 2025
Merged

Revert "feat: conditionally set headers (if not already set) in redirect response (#190)" #200

merged 1 commit into from
Mar 27, 2025
+6 −27

Conversation

Phillip9587
Copy link
Contributor

This reverts commit b51ab84

Ref: #197 (comment)

@Phillip9587 Phillip9587 mentioned this pull request Mar 27, 2025
Open
wesleytodd
wesleytodd approved these changes Mar 27, 2025
View reviewed changes
Copy link
Member

@wesleytodd wesleytodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer this approach as well, it avoids a new change and we can just queue it up for the next release to bring it back safely or deprecate then. The other approach is a change and we'd be rushing it out which I don't like.

@UlisesGascon UlisesGascon merged commit 2e22086 into expressjs:master Mar 27, 2025
18 checks passed
@UlisesGascon UlisesGascon self-assigned this Mar 27, 2025
@UlisesGascon UlisesGascon mentioned this pull request Mar 27, 2025
Merged
@Phillip9587 Phillip9587 deleted the revert-conditional-headers branch March 27, 2025 21:15
@Phillip9587 Phillip9587 mentioned this pull request Mar 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleytodd wesleytodd

@UlisesGascon UlisesGascon

@bjohansebas bjohansebas

Assignees

@UlisesGascon UlisesGascon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Phillip9587 @wesleytodd @UlisesGascon @bjohansebas