Skip to content

Add missing ws package types #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2024
Merged

Add missing ws package types #174

merged 1 commit into from
Sep 7, 2024

Conversation

cezaraugusto
Copy link
Member

Fix #171

@cezaraugusto cezaraugusto requested a review from OSpoon September 6, 2024 18:15
@cezaraugusto cezaraugusto self-assigned this Sep 6, 2024
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Sep 6, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/extension-js/extension.js/extension@174

pnpm add https://pkg.pr.new/extension-js/extension.js/extension-create@174

pnpm add https://pkg.pr.new/extension-js/extension.js/extension-develop@174

commit: acc2fbf

@codecov Codecov
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

see 5 files with indirect coverage changes

OSpoon
OSpoon approved these changes Sep 7, 2024
View reviewed changes
Copy link
Member

@OSpoon OSpoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great~, It is indeed useful for me, thanks~

@cezaraugusto cezaraugusto merged commit e72d98c into main Sep 7, 2024
14 checks passed
@cezaraugusto cezaraugusto deleted the ws-types branch September 7, 2024 04:07
@cezaraugusto
Copy link
Member Author

Available in v2.0.0-alpha.28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OSpoon OSpoon OSpoon approved these changes

Assignees

@cezaraugusto cezaraugusto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running pnpm tsc will show that the ws module type is missing.
2 participants
@cezaraugusto @OSpoon