Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add keybinding to copy commit message #2376

Closed
wants to merge 1 commit into from

Conversation

wugeer
Copy link
Contributor

@wugeer wugeer commented Sep 30, 2024

This Pull Request fixes/closes #2370 .

It changes the following:

  • add keybinding to copy commit message
  • Run cargo clippy to format the code.

I followed the checklist:

  • I added unittests
  • I ran make check without errors
  • I tested the overall application
  • I added an appropriate item to the changelog
2024-09-30.17-20-22.webm

@extrawurst Is it necessary to add a feature to copy the commit subject here? :)

@extrawurst
Copy link
Owner

lets put that functionality into DetailsComponent - this makes it a few more key strokes away but it is not common enough to do to add on the commit-log level

@wugeer
Copy link
Contributor Author

wugeer commented Jan 11, 2025

lets put that functionality into DetailsComponent - this makes it a few more key strokes away but it is not common enough to do to add on the commit-log level

@extrawurst I have a doubt, why can the function copy_commit_hash be put in commitlist? I think these two are in the same place.

@extrawurst
Copy link
Owner

I think these two are in the same place.

what are you saying? what two are in the same place?

my problem is that the commit log view is by far the one with the most available commands. i wont add another niche one that easily makes sense to be in the details of a specific commit.

@wugeer
Copy link
Contributor Author

wugeer commented Jan 12, 2025

@extrawurst Sorry, I misunderstood you. Since this feature may cause trouble to people, I will close this PR. Thank you for your guidance.

@wugeer wugeer closed this Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

keybinding to copy commit message
2 participants