Skip to content

Fix version discrepancy between code, package.json, and GitHub releases #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ichoosetoaccept
Copy link

Fix Version Discrepancy Issues

Problem

There were multiple version inconsistencies in the Task Master CLI:

  1. The hardcoded version in utils.js was "1.5.0"
  2. The package.json version was "0.9.30"
  3. The GitHub release was "v0.10.2"
  4. The version detection logic was unreliable, sometimes showing the wrong version

Solution

This PR fixes these issues by:

  1. Removing the hardcoded version in utils.js
  2. Updating the package.json version to match the GitHub release (0.10.2)
  3. Improving the version detection logic to reliably find and use the correct version
  4. Adding better error handling with debug logging

Testing

Verified that task-master --version and the banner in task-master --help both correctly show version 0.10.2.

This ensures consistent versioning across the codebase and GitHub releases, providing a clear path forward for future releases.

Copy link

changeset-bot bot commented Apr 4, 2025

⚠️ No Changeset found

Latest commit: 5c24f62

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@eyaltoledano eyaltoledano added the bug Something isn't working label Apr 5, 2025
@eyaltoledano eyaltoledano moved this from Triage to Review in Taskmaster Core Apr 5, 2025
@Crunchyman-ralph Crunchyman-ralph changed the base branch from main to next April 8, 2025 22:27
Copy link
Collaborator

@Crunchyman-ralph Crunchyman-ralph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to accept this PR, if you can just clean it up and fix conflicts, I'd love to give it another review

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change, think its important

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this, will be fixed separetly, its due to a different issue

Copy link
Collaborator

@Crunchyman-ralph Crunchyman-ralph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

view requested changes in history

@Crunchyman-ralph Crunchyman-ralph changed the base branch from next to ichoosetoaccept/fix-version-discrepancy April 18, 2025 21:39
@Crunchyman-ralph
Copy link
Collaborator

Taking over this PR

@Crunchyman-ralph Crunchyman-ralph changed the base branch from ichoosetoaccept/fix-version-discrepancy to next April 18, 2025 21:40
@Crunchyman-ralph
Copy link
Collaborator

Changed my mind, we'll come back to this later, keeping it as is for now

@github-project-automation github-project-automation bot moved this from Review to Done in Taskmaster Core Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants