-
-
Notifications
You must be signed in to change notification settings - Fork 368
chore: Upgrade FreeBSD / OpenBSD in CI. #1669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
64ec8f1 to
37b344c
Compare
37b344c to
b13eb9e
Compare
20578fe to
847ea97
Compare
Until we can add support for OpenBSD in rustup.
847ea97 to
14c49c3
Compare
| set -e | ||
| export CARGO_TERM_COLOR="always" | ||
| export RUSTFLAGS="--deny warnings" | ||
| # Do not treat warnings as failure, since OpenBSD lags behind "rustup" versions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cafkafk: I am aware that the following change is not the most ideal, but it should still run the tests in the CI against OpenBSD.
With 7.7 reaching EoL in about 4 months (at the time of writing), the CI in due course of time may fail to fetch packages for 7.7 via pkg_add
Looking at the issues from
It looks like there is a bit of effort involved in making rustup pickup and support OpenBSD too since it is considered a tier 3 platform.
For now this work around is the best solution I can think of, until I can figure out a way to get it to play along like the other two BSDs.
Let me know, what you think and if this is an acceptable compromise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
gierens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, as well. Disabling warnings and clippy only on FreeBSD/OpenBSD shouldn't be a problem. Anything relevant they might flag, should also be caught by the CI jobs for the other platforms.
Warnings / clippy are disabled only for OpenBSD, since FreeBSD has proper rustup support. |
Thanks for the hint, yeah, then it seems even less of a problem. |
7.8.15.0.Release notes can be found here: