Skip to content

fix: type checking errors in tools directory #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ezyang
Copy link
Owner

@ezyang ezyang commented Mar 25, 2025

Stack from ghstack (oldest at bottom):

Typecheck and fix all errors in codemcp/tools/

79b88dc  (Base revision)
950c78a  Add AsyncAbortSignal protocol for type checking
2bf74a9  Import AsyncAbortSignal in chmod.py
fc9a1a3  Add AsyncAbortSignal type annotation to chmod function
21d64ee  Ensure chat_id is not None when calling commit_changes
b472620  Import AsyncAbortSignal in git_blame.py
9350d33  Add AsyncAbortSignal type annotation to git_blame function
e712304  Remove codemcp/signal_types.py: Remove unnecessary signal_types.py
dff8f2a  Remove unnecessary AsyncAbortSignal import in chmod.py
86c5519  Change signal parameter type to Any in chmod.py
21c0a41  Remove unnecessary AsyncAbortSignal import in git_blame.py
af0ea51  Change signal parameter type to Any in git_blame.py
a7aa14f  Add proper type annotation for signal parameter in git_diff.py
21ddade  Add proper type annotation for signal parameter in git_log.py
beb86ab  Remove unused signal parameter from git_show.py
5862d82  Remove unused signal parameter from git_blame.py
9e37110  Remove unused signal parameter from git_diff.py
6d3d32a  Remove unused signal parameter from git_log.py
38d525f  Remove unused signal parameter from chmod.py
f11bd7a  Remove signal parameter from chmod.py docstring
758b714  Remove signal parameter from git_blame.py docstring
9580448  Remove signal parameter from git_diff.py docstring
5185135  Remove signal parameter from git_log.py docstring
d07756a  Remove signal parameter from git_show.py docstring
56af8e6  Remove unused signal parameter from glob.py
d0c0a3e  Remove signal parameter from glob.py docstring
acc9507  Remove unused signal parameter from glob_files function
be65e0e  Remove signal parameter from glob_files docstring
a08963b  Remove unused signal parameter from git_grep function
f98cc86  Remove signal parameter from git_grep docstring
793a395  Remove unused signal parameter from grep_files function
d80863a  Remove signal parameter from grep_files docstring
1286918  Update git_grep call to remove signal parameter
17d29cf  Fix split() in grep.py to correctly split string
7be44fd  Initialize best_match_i to fix possible unbound variable error
38320cd  Initialize best_match with empty list to avoid None checks
def9944  Add check for empty search_lines or content_lines
a08d108  Add proper type annotation for dict in apply_edit return type
5232434  Add Any to imports in edit_file.py
a3a5f83  Fix zip function call in try_dotdotdots to handle type checking correctly
35fd1cf  Fix default value for chat_id to use empty string instead of None
28acdaa  Fix default value for chat_id to use empty string instead of None
c351e11  Fix default value for chat_id to use empty string instead of None
8739877  Add required type imports in init_project.py
3006ef7  Add proper type annotation for command_docs parameter
3b1f3fa  Fix description parameter type in _generate_chat_id function
f6ef39c  Fix unused variables in init_project.py by using _ to discard returned values
1096afc  Remove unused Optional import
56b2265  Remove unused Any import
614362e  Fix unused variable 'patch' in edit_file.py by using _ to discard returned value
8f27a3d  Fix glob function call to remove signal parameter
09a56ce  Handle None case for command_list in run_command.py
HEAD     Update run_code_command call to use actual_command

codemcp-id: 227-fix-type-checking-errors-in-tools-directory

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Mar 25, 2025
Typecheck and fix all errors in codemcp/tools/

```git-revs
79b88dc  (Base revision)
950c78a  Add AsyncAbortSignal protocol for type checking
2bf74a9  Import AsyncAbortSignal in chmod.py
fc9a1a3  Add AsyncAbortSignal type annotation to chmod function
21d64ee  Ensure chat_id is not None when calling commit_changes
b472620  Import AsyncAbortSignal in git_blame.py
9350d33  Add AsyncAbortSignal type annotation to git_blame function
e712304  Remove codemcp/signal_types.py: Remove unnecessary signal_types.py
dff8f2a  Remove unnecessary AsyncAbortSignal import in chmod.py
86c5519  Change signal parameter type to Any in chmod.py
21c0a41  Remove unnecessary AsyncAbortSignal import in git_blame.py
af0ea51  Change signal parameter type to Any in git_blame.py
a7aa14f  Add proper type annotation for signal parameter in git_diff.py
21ddade  Add proper type annotation for signal parameter in git_log.py
beb86ab  Remove unused signal parameter from git_show.py
5862d82  Remove unused signal parameter from git_blame.py
9e37110  Remove unused signal parameter from git_diff.py
6d3d32a  Remove unused signal parameter from git_log.py
38d525f  Remove unused signal parameter from chmod.py
f11bd7a  Remove signal parameter from chmod.py docstring
758b714  Remove signal parameter from git_blame.py docstring
9580448  Remove signal parameter from git_diff.py docstring
5185135  Remove signal parameter from git_log.py docstring
d07756a  Remove signal parameter from git_show.py docstring
56af8e6  Remove unused signal parameter from glob.py
d0c0a3e  Remove signal parameter from glob.py docstring
acc9507  Remove unused signal parameter from glob_files function
be65e0e  Remove signal parameter from glob_files docstring
a08963b  Remove unused signal parameter from git_grep function
f98cc86  Remove signal parameter from git_grep docstring
793a395  Remove unused signal parameter from grep_files function
d80863a  Remove signal parameter from grep_files docstring
1286918  Update git_grep call to remove signal parameter
17d29cf  Fix split() in grep.py to correctly split string
7be44fd  Initialize best_match_i to fix possible unbound variable error
38320cd  Initialize best_match with empty list to avoid None checks
def9944  Add check for empty search_lines or content_lines
a08d108  Add proper type annotation for dict in apply_edit return type
5232434  Add Any to imports in edit_file.py
a3a5f83  Fix zip function call in try_dotdotdots to handle type checking correctly
35fd1cf  Fix default value for chat_id to use empty string instead of None
28acdaa  Fix default value for chat_id to use empty string instead of None
c351e11  Fix default value for chat_id to use empty string instead of None
8739877  Add required type imports in init_project.py
3006ef7  Add proper type annotation for command_docs parameter
3b1f3fa  Fix description parameter type in _generate_chat_id function
f6ef39c  Fix unused variables in init_project.py by using _ to discard returned values
1096afc  Remove unused Optional import
56b2265  Remove unused Any import
614362e  Fix unused variable 'patch' in edit_file.py by using _ to discard returned value
8f27a3d  Fix glob function call to remove signal parameter
09a56ce  Handle None case for command_list in run_command.py
HEAD     Update run_code_command call to use actual_command
```

codemcp-id: 227-fix-type-checking-errors-in-tools-directory
ghstack-source-id: f43e837
Pull-Request-resolved: #217
@ezyang ezyang closed this in 1cad4e8 Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant