Skip to content

Conversation

cNorspang
Copy link

added 0.0.0.0 to allowed hosts, for easier testing on other devices than host device

Copy link
Member

@hrjakobsen hrjakobsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would add 0.0.0.0 to the allowed hosts on the production server as well, which I don't think we want.

@cNorspang cNorspang requested a review from hrjakobsen October 6, 2021 13:11
@VirtualSatai
Copy link
Collaborator

This would add 0.0.0.0 to the allowed hosts on the production server as well, which I don't think we want.
@hrjakobsen

Does the production server use local.cfg.skel? I would expect that we have previously made a local.cfg that is not tracked in git (https://github.com/f-klubben/stregsystemet/blob/next/.gitignore#L4) that it uses. I don't have access to the server anymore (since AAU closed all port 22 connections)

The local.cfg.skel is just a skeleton for new users to have a start for their own local.cfg file.

I could be wrong, but I think changing this file in the repo is fine.

@hrjakobsen
Copy link
Member

@VirtualSatai previously the PR changed treo/settings.py instead of local.cfg.skel. The change now should be fine.

Copy link
Member

@hrjakobsen hrjakobsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the change being done to local.cfg.skel the security implications is left to the developer, which I like. I'm probably still leaning towards leaning towards leaving the safest option the default (localhost and 127.0.0.1) and let the unsafer option be "opt-in". With that said, I'm not opposed to this change.

@hrjakobsen hrjakobsen dismissed their stale review October 6, 2021 20:45

No longer relevant after code update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants