[#14] feat: add standings feature with data fetching and display in Season results components #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

wooder2050 merged 3 commits into main from feature/standings-penalty-rule

Jul 14, 2025

Collaborator

wooder2050 commented Jul 14, 2025

주요 변경사항

1. standings 테이블 UI 개선

standings 테이블에서 '무' 컬럼(무승부) 완전 제거
1~3위 순위 앞에 각각 🥇, 🥈, 🥉 이모지 노출
이모지 변환 로직을 getRankEmoji 함수로 분리하여 코드 가독성 향상

2. 코드 리팩토링

StandingsTable 컴포넌트에서 React.FC → FC로 변경
getRankEmoji 함수 분리 및 적용

적용 화면

시즌1, 시즌2, 파일럿 시즌 결과 페이지에서 순위표가 실제 리그 규칙에 맞게 노출됨
1~3위는 메달 이모지, 4위 이하부터는 숫자만 표시


          feat: add standings feature with data fetching and display in Season …

c577d91

…results components

wooder2050 self-assigned this

wooder2050 added 2 commits

July 14, 2025 23:12


          feat: add loading state to StandingsTable for improved user experience

d6343c1


          feat: enhance StandingsTable with loading and error states for better…

20b6db6

… user feedback

sonarqubecloud bot commented Jul 14, 2025

Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

wooder2050 merged commit b4ef14e into main

1 of 2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet