feat: 컨트롤러 분리, 카드상세 확인 코인조회, 충전 추가 #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-lab-nolan
reviewed
Nov 20, 2024
| userCoinLog = new UserCoinLog(objectMapper.readValue(message, UserCoinLogVO.class)); | ||
| } catch (JsonProcessingException e) { | ||
| throw new RuntimeException(e); | ||
| } |
There was a problem hiding this comment.
Exception이 나면 kafka에 미처리 상태로 남아서 무한 반복 시도 문제 고려
f-lab-nolan
reviewed
Nov 20, 2024
|
|
||
| private final UserCardService userCardService; | ||
|
|
||
| @GetMapping(value = "/v1/users/cards") |
There was a problem hiding this comment.
@GetMapping(value = "/v1/users/{userId}/cards")
userId = 로그인 아이디 아님. 해당 테이블의 시퀀스
f-lab-nolan
reviewed
Nov 20, 2024
| userCardService.setCard(authentication.getPrincipal().toString()); | ||
| } | ||
|
|
||
| @GetMapping(value = "/v1/users/cards/detail/{targetId}") |
There was a problem hiding this comment.
/v1/users/{userId}/target-users -> target의 목록
/v1/users/{userId}/target-users/cards -> target들의 전체 카드 목록
/v1/users/{userId}/target-users/{targetId}/cards
/v1/users/{userId}/target-users/all-cards
/v1/users/{userId}/target-users
/v1/users/{userId}/target-users/{targetId}
/v1/users/{userId}/target-users/{targetId}/cards
/v1/users/{userId}/target-users/{targetId}/cards/{cardId}
/v1/users/{userId}/target-users/target-users-cards
f-lab-nolan
reviewed
Nov 20, 2024
| private final KafkaProducer kafkaProducer; | ||
| private final ObjectMapper objectMapper; | ||
|
|
||
| @GetMapping(value = "/v1/users/coin") |
There was a problem hiding this comment.
/v1/users/{userId}/coins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
컨트롤러 분리, 카드상세 확인 코인조회, 충전 추가