feature: id찾기 기능 추가 #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-lab-nolan
reviewed
Jun 4, 2025
| //public String getVerificationCode(final UserValidationDTO userValidationDTO) { | ||
| //public String getVerificationCode(final UserValidationDTO userValidationDTO) { | ||
|
|
||
| User user = this.verifyUserByPhone(UserValidationVO.phone()); |
There was a problem hiding this comment.
폰번호로 사용자를 찾는거인데.
보통 일반적인 회사에서는
본인인증을 통한 CI값으로 사용자를 찾아서 sms나 이메일이나 인증 코드 보냄
There was a problem hiding this comment.
우리나라 법상 돈을 거래하거나 물건을 사고 파는 시스템은 무조건 사용자 본인인증을 필수로 받아야 함
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
id찾기 기능 추가