Skip to content

Conversation

@AoGao-Kedoka
Copy link
Contributor

@AoGao-Kedoka AoGao-Kedoka commented Jan 9, 2026

Describe your changes

  • Renamed vtkF3DTAAResolvePass into vtkF3DTAAPass
  • Decoupled jittering logic from vtkF3DRenderer into vtkF3DTAAPass
  • visually it should behave same as before

Issue ticket number and link if any

#2371

Checklist for finalizing the PR

  • I have performed a self-review of my code
  • I have added tests for new features and bugfixes
  • I have added documentation for new features
  • If it is a modifying the libf3d API, I have updated bindings
  • If it is a modifying the .github/workflows/versions.json, I have updated docker_timestamp

Continuous integration

Please write a comment to run CI, eg: \ci fast.
See here for more info.

Decoupling jittering logic from vtkF3DRenderer into vtkF3DTAAPass
@AoGao-Kedoka
Copy link
Contributor Author

\ci fast

@Meakk
Copy link
Member

Meakk commented Jan 10, 2026

Indeed that's much better! Can you check if it still works with point sprites too?

@mwestphal
Copy link
Member

Indeed that's much better! Can you check if it still works with point sprites too?

lets test it if not already ? :)

Copy link
Member

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I defer to @Meakk

@AoGao-Kedoka
Copy link
Contributor Author

Indeed that's much better! Can you check if it still works with point sprites too?

yes, it works for point sprites, tested with points.ply

@AoGao-Kedoka
Copy link
Contributor Author

\ci full

@codecov
Copy link

codecov bot commented Jan 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.69%. Comparing base (6930f0c) to head (c190400).
⚠️ Report is 27 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2798      +/-   ##
==========================================
+ Coverage   96.64%   96.69%   +0.05%     
==========================================
  Files         142      152      +10     
  Lines       12923    13104     +181     
==========================================
+ Hits        12489    12671     +182     
+ Misses        434      433       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants