-
-
Notifications
You must be signed in to change notification settings - Fork 365
TAA Improvement #2798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
TAA Improvement #2798
Conversation
Decoupling jittering logic from vtkF3DRenderer into vtkF3DTAAPass
|
\ci fast |
|
Indeed that's much better! Can you check if it still works with point sprites too? |
lets test it if not already ? :) |
mwestphal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I defer to @Meakk
yes, it works for point sprites, tested with points.ply |
|
\ci full |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2798 +/- ##
==========================================
+ Coverage 96.64% 96.69% +0.05%
==========================================
Files 142 152 +10
Lines 12923 13104 +181
==========================================
+ Hits 12489 12671 +182
+ Misses 434 433 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Describe your changes
vtkF3DTAAResolvePassintovtkF3DTAAPassIssue ticket number and link if any
#2371
Checklist for finalizing the PR
.github/workflows/versions.json, I have updateddocker_timestampContinuous integration
Please write a comment to run CI, eg:
\ci fast.See here for more info.