Skip to content

Conversation

@AoGao-Kedoka
Copy link
Contributor

@AoGao-Kedoka AoGao-Kedoka commented Jan 9, 2026

Describe your changes

  • Renamed vtkF3DTAAResolvePass into vtkF3DTAAPass
  • Decoupled jittering logic from vtkF3DRenderer into vtkF3DTAAPass
  • visually it should behave same as before

Issue ticket number and link if any

#2371

Checklist for finalizing the PR

  • I have performed a self-review of my code
  • I have added tests for new features and bugfixes
  • I have added documentation for new features
  • If it is a modifying the libf3d API, I have updated bindings
  • If it is a modifying the .github/workflows/versions.json, I have updated docker_timestamp

Continuous integration

Please write a comment to run CI, eg: \ci fast.
See here for more info.

Decoupling jittering logic from vtkF3DRenderer into vtkF3DTAAPass
@AoGao-Kedoka
Copy link
Contributor Author

\ci fast

@Meakk
Copy link
Member

Meakk commented Jan 10, 2026

Indeed that's much better! Can you check if it still works with point sprites too?

@mwestphal
Copy link
Member

Indeed that's much better! Can you check if it still works with point sprites too?

lets test it if not already ? :)

Copy link
Member

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I defer to @Meakk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants