Conversation
|
You are modifying libf3d public API! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1860 +/- ##
==========================================
- Coverage 96.13% 96.11% -0.03%
==========================================
Files 130 130
Lines 11690 11702 +12
==========================================
+ Hits 11238 11247 +9
- Misses 452 455 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Do you need any help or review to move forward @0xfedcafe ? |
Just that upper question about an optional and I’ll push hopefully the final commit for this task with the test |
|
Hi @0xfedcafe How is it going ? Do you need any help ? |
|
Hi @0xfedcafe Please do not hesitate to reach out if you need any guidance :) |
mwestphal
left a comment
mwestphal
left a comment
There was a problem hiding this comment.
It getting there! I've added what is needed for the CI to run the next time you push,
0xfedcafe
force-pushed
the
cli-reader-options
branch
from
8b9cde1 to
a110778
Compare
Update application/F3DOptionsTools.cxx Co-authored-by: Mathieu Westphal <[email protected]> Update library/src/scene_impl.cxx Co-authored-by: Mathieu Westphal <[email protected]> Apply suggestions from code review Co-authored-by: Mathieu Westphal <[email protected]> merge fix sdk test sdk test & pr review suggestions path check fix fixes
0xfedcafe
force-pushed
the
cli-reader-options
branch
from
a110778 to
e25b256
Compare
|
Looks like I forgot this @0xfedcafe , sorry about that. Is this ready to be merged on your side ? |
Hi, yep, I hope I haven’t missed something |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
0xfedcafe
force-pushed
the
cli-reader-options
branch
from
866fa38 to
0b420b5
Compare
0xfedcafe
force-pushed
the
cli-reader-options
branch
from
0b420b5 to
7141d9e
Compare
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Thanks for your contribution @0xfedcafe ! |
2 participants
Describe your changes
Added a CLI reader option #1735
Issue ticket number and link if any
#1735
Checklist for finalizing the PR
.github/workflows/versions.json, I have updatedtimestampContinuous integration
Please check the checkbox of the CI you want to run, then push again on your branch.