WIP : Jump to animation keyframe #2589
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 21 commits
October 31, 2025 11:17
Ni-g-3l
changed the title
added 5 commits
December 4, 2025 17:16
Contributor
Author
|
\ci main |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2589 +/- ##
==========================================
- Coverage 96.66% 96.65% -0.02%
==========================================
Files 142 142
Lines 12918 12958 +40
==========================================
+ Hits 12487 12524 +37
- Misses 431 434 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mwestphal
reviewed
Jan 7, 2026
mwestphal
reviewed
Jan 7, 2026
mwestphal
reviewed
Jan 7, 2026
| command_documentation_t{ "reset_camera", "reset the camera to its original location" }); | ||
|
|
||
| this->addCommand( | ||
| "jump_to_keyframe", |
mwestphal
requested changes
Jan 7, 2026
Member
mwestphal
left a comment
mwestphal
left a comment
There was a problem hiding this comment.
small doc improvements needed
Member
|
\ci full |
Co-authored-by: Mathieu Westphal <[email protected]>
Co-authored-by: Mathieu Westphal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR allows user to play animation frame by frame
frame_by_frame_anim.mp4
However, it is based on GetTemporalInformation from vtkImporter, so It will works only for native VTK Importer for now.
Attach here a GLTF file with an animation if you want to test.
AnimatedCube.zip
Issue ticket number and link if any
#2559
#2682
Checklist for finalizing the PR
.github/workflows/versions.json, I have updateddocker_timestampContinuous integration
Please write a comment to run CI, eg:
\ci fast.See here for more info.